bastiaan/videodinges
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Do not generate uneccessary objects

Browse Source
This commit is contained in:
Bastiaan Welmers
2020-05-07 22:49:38 +02:00
parent 146df2d3b1
commit de2d58356b
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/videodinges/factories.py
View File

@@ -16,7 +16,8 @@ def create(model: Type[T], **kwargs) -> T:
return models.Video.objects.create(**{**dict(title='Title', slug='slug', description='Description'), **kwargs}) return models.Video.objects.create(**{**dict(title='Title', slug='slug', description='Description'), **kwargs})
if model is models.Transcoding: if model is models.Transcoding:
video = create(models.Video, title='Title', slug='slug', description='Description') video = create(models.Video, title='Title', slug='slug', description='Description') \
if 'video' not in kwargs else None
return models.Transcoding.objects.create( return models.Transcoding.objects.create(
**{ **{
**dict( **dict(
@@ -34,7 +35,9 @@ def create(model: Type[T], **kwargs) -> T:
@override_settings(MEDIA_ROOT=tempfile.mkdtemp()) @override_settings(MEDIA_ROOT=tempfile.mkdtemp())
def _upload(**kwargs): def _upload(**kwargs):
return models.Upload.objects.create(**{**dict(file=SimpleUploadedFile('some_file.txt', b'some contents')), **kwargs}) file = SimpleUploadedFile('some_file.txt', b'some contents') \
if 'file' not in kwargs else None
return models.Upload.objects.create(**{**dict(file=file), **kwargs})
# TODO fix annoying dict notation to something more gentle. # TODO fix annoying dict notation to something more gentle.