From de2d58356b947c775f75d890a6990ef79c8ce89e Mon Sep 17 00:00:00 2001
From: Bastiaan Welmers <bastiaan@welmers.net>
Date: Thu, 7 May 2020 22:49:38 +0200
Subject: [PATCH] Do not generate uneccessary objects

---
 tests/videodinges/factories.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/videodinges/factories.py b/tests/videodinges/factories.py
index d1c6be6..ba64222 100644
--- a/tests/videodinges/factories.py
+++ b/tests/videodinges/factories.py
@@ -16,7 +16,8 @@ def create(model: Type[T], **kwargs) -> T:
 		return models.Video.objects.create(**{**dict(title='Title', slug='slug', description='Description'), **kwargs})
 
 	if model is models.Transcoding:
-		video = create(models.Video, title='Title', slug='slug', description='Description')
+		video = create(models.Video, title='Title', slug='slug', description='Description') \
+			if 'video' not in kwargs else None
 		return models.Transcoding.objects.create(
 			**{
 				**dict(
@@ -34,7 +35,9 @@ def create(model: Type[T], **kwargs) -> T:
 
 @override_settings(MEDIA_ROOT=tempfile.mkdtemp())
 def _upload(**kwargs):
-	return models.Upload.objects.create(**{**dict(file=SimpleUploadedFile('some_file.txt', b'some contents')), **kwargs})
+	file = SimpleUploadedFile('some_file.txt', b'some contents') \
+		if 'file' not in kwargs else None
+	return models.Upload.objects.create(**{**dict(file=file), **kwargs})
 
 
 # TODO fix annoying dict notation to something more gentle.