Made code more robust against missing cache items

src/digimarks/main.py

@@ -34,6 +34,8 @@ class Settings(BaseSettings):
     favicons_dir: DirectoryPath
 
     # inside the codebase
+    # static_dir: DirectoryPath = Path('digimarks/static')
+    # template_dir: DirectoryPath = Path('digimarks/templates')
     static_dir: DirectoryPath = 'digimarks/static'
     template_dir: DirectoryPath = 'digimarks/templates'
 

src/digimarks/static/js/digimarks.js

@@ -18,6 +18,7 @@ document.addEventListener('alpine:init', () => {
         /* Bookmark that is being edited, used to fill the form, etc. */
         bookmarkToEdit: Alpine.$persist({}).as('bookmarkToEdit'),
         bookmarkToEditError: null,
+        bookmarkToEditVisible: false,
 
         /* Loading indicator */
         loading: false,
@@ -147,6 +148,10 @@ document.addEventListener('alpine:init', () => {
             )
         },
         get filteredTags() {
+            if (this.cache[this.userKey].tags === undefined) {
+                console.log('Tags not yet cached');
+                return [];
+            }
             /* Search in the list of all tags */
             return this.cache[this.userKey].tags.filter(
                 i => i.match(new RegExp(this.search, "i"))
@@ -214,7 +219,6 @@ document.addEventListener('alpine:init', () => {
                 'note': '',
                 'tags': ''
             }
-
         },
         async startAddingBookmark() {
             /* Open 'add bookmark' page */
@@ -222,6 +226,7 @@ document.addEventListener('alpine:init', () => {
             this.resetEditBookmark();
             // this.show_bookmark_details = true;
             const editFormDialog = document.getElementById("editFormDialog");
+            this.bookmarkToEditVisible = true;
             editFormDialog.showModal();
         },
         async bookmarkURLChanged() {
@@ -253,6 +258,7 @@ document.addEventListener('alpine:init', () => {
         },
         async saveBookmark() {
             console.log('Saving bookmark');
+            // this.bookmarkToEditVisible = false;
             // this.show_bookmark_details = false;
         },
         async addBookmark() {

src/digimarks/templates/user_index.html

@@ -185,7 +185,8 @@
             </span>
                 </div>
 #}
-                <form method="dialog" id="bookmarkEditForm" x-if="$store.digimarks.bookmarkToEdit">
+                <template x-if="$store.digimarks.bookmarkToEditVisible">
+                    <form method="dialog" id="bookmarkEditForm">
                         <fieldset class="form-group">
                             <label for="bookmark_url">URL</label>
                             <input id="bookmark_url" type="text" name="bookmark_url" placeholder="url"
@@ -210,7 +211,8 @@
                                    placeholder="tags, divided bij comma's"
                                    x-model="$store.digimarks.bookmarkToEdit.tags">
                         </fieldset>
-                    <p x-show="$store.digimarks.bookmarkToEditError" x-data="$store.digimarks.bookmarkToEditError"></p>
+                        <p x-show="$store.digimarks.bookmarkToEditError"
+                           x-data="$store.digimarks.bookmarkToEditError"></p>
                         <p>
                             <label>
                                 <input type="checkbox" name="strip" id="strip"/>
@@ -222,6 +224,7 @@
                             <button @click="$store.digimarks.saveBookmark()">Save</button>
                         </div>
                     </form>
+                </template>
             </dialog>
         </main>