From 9f467f8a09e4c8269607ba28eaf352a96201ab2f Mon Sep 17 00:00:00 2001 From: Michiel Scholten Date: Sat, 17 Mar 2018 16:21:31 +0100 Subject: [PATCH] Some more readability fixes --- CHANGELOG.md | 1 + digimarks.py | 11 ++++++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 773b955..a72ed23 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,6 +40,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - jQuery-b-gone: changed all jQuery code to regular JavaScript code/MaterializeCSS framework - Fixed colour of filter text in search field for dark themes - Unified rendering of 'private' and 'public' views of bookmark cards +- Code cleanups, readability fixes ## [1.1.0] - 2017-07-22 diff --git a/digimarks.py b/digimarks.py index b5f5742..af3560a 100644 --- a/digimarks.py +++ b/digimarks.py @@ -343,8 +343,7 @@ class Bookmark(BaseModel): self.http_status = result.status_code self.redirect_uri = result.url return result.url - else: - return None + return None def get_uri_domain(self): parsed = urlparse(self.url) @@ -360,8 +359,7 @@ class Bookmark(BaseModel): """ Get the tags as a list, iterable in template """ if self.tags: return self.tags.split(',') - else: - return [] + return [] def to_dict(self): result = { @@ -666,7 +664,10 @@ def deletingbookmark(userkey, urlhash): """ Delete the bookmark from form submit by /delete """ query = Bookmark.update(status=Bookmark.DELETED).where(Bookmark.userkey == userkey, Bookmark.url_hash == urlhash) query.execute() - query = Bookmark.update(deleted_date = datetime.datetime.now()).where(Bookmark.userkey == userkey, Bookmark.url_hash == urlhash) + query = Bookmark.update(deleted_date=datetime.datetime.now()).where( + Bookmark.userkey == userkey, + Bookmark.url_hash == urlhash + ) query.execute() message = 'Bookmark deleted. Undo deletion'.format(url_for( 'undeletebookmark',