From f8a3151672d81d7cddf008257b2be0e46b6a1419 Mon Sep 17 00:00:00 2001
From: Bastiaan Welmers <bastiaan@welmers.net>
Date: Fri, 8 May 2020 22:17:56 +0200
Subject: [PATCH] Better video tag test

---
 tests/videodinges/views/test_video.py | 82 +++++++++------------------
 1 file changed, 26 insertions(+), 56 deletions(-)

diff --git a/tests/videodinges/views/test_video.py b/tests/videodinges/views/test_video.py
index 3bad763..defa2cf 100644
--- a/tests/videodinges/views/test_video.py
+++ b/tests/videodinges/views/test_video.py
@@ -57,23 +57,13 @@ class VideoTestCase(TestCase):
 		srctag = '<source src="{url}" type="{type}" />'
 
 		self.assertInHTML(
-			srctag.format(url=transcoding1.url, type=transcoding1.type),
+			"""<video width="853" height="480" controls="controls">
+				<source src="http://480p.mp4" type='video/mp4' />
+				<source src="http://480p.webm" type='video/webm' />
+				You need a browser that understands HTML5 video and supports h.264 or vp8 codecs.
+			</video>""",
 			content,
 		)
-		self.assertInHTML(
-			srctag.format(url=transcoding2.url, type=transcoding2.type),
-			content
-		)
-		self.assertInHTML(
-			srctag.format(url=transcoding3.url, type=transcoding3.type),
-			content,
-			count=0
-		)
-		self.assertInHTML(
-			srctag.format(url=transcoding4.url, type=transcoding4.type),
-			content,
-			count=0
-		)
 
 		self.assertInHTML('<title>Vid 1</title>', content)
 
@@ -88,11 +78,6 @@ class VideoTestCase(TestCase):
 			content
 		)
 
-		self.assertIn(
-			'You need a browser that understands HTML5 video and supports h.264 or vp8 codecs.',
-			content
-		)
-
 		self.assertInHTML(
 			'<script src="static/js/video.js" type="text/javascript"></script>',
 			content
@@ -141,26 +126,15 @@ class VideoTestCase(TestCase):
 
 		content:str = resp.content.decode(resp.charset)
 
-		srctag = '<source src="{url}" type="{type}" />'
+		self.assertInHTML(
+			"""<video width="1280" height="720" controls="controls">
+				<source src="http://720p.mp4" type='video/mp4' />
+				<source src="http://720p.webm" type='video/webm' />
+				You need a browser that understands HTML5 video and supports h.264 or vp8 codecs.
+			</video>""",
+			content,
+		)
 
-		self.assertInHTML(
-			srctag.format(url=transcoding1.url, type=transcoding1.type),
-			content,
-			count=0
-		)
-		self.assertInHTML(
-			srctag.format(url=transcoding2.url, type=transcoding2.type),
-			content,
-			count=0
-		)
-		self.assertInHTML(
-			srctag.format(url=transcoding3.url, type=transcoding3.type),
-			content,
-		)
-		self.assertInHTML(
-			srctag.format(url=transcoding4.url, type=transcoding4.type),
-			content,
-		)
 
 		self.assertInHTML(
 			'<a href="vid-1.html?quality=480p" onclick="vidTimeInUrl(this);">480p versie</a>',
@@ -213,23 +187,19 @@ class VideoTestCase(TestCase):
 
 		content:str = resp.content.decode(resp.charset)
 
-		srctag = '<source src="{url}" type="{type}" />'
+		self.assertInHTML(
+			"""<video width="1280" height="720" controls="controls">
+				<source src="http://720p.mp4" type='video/mp4' />
+				<source src="http://720p.webm" type='video/webm' />
+				You need a browser that understands HTML5 video and supports h.264 or vp8 codecs.
+			</video>""",
+			content,
+		)
+
 
 		self.assertInHTML(
-			srctag.format(url=transcoding1.url, type=transcoding1.type),
-			content,
-			count=0
-		)
-		self.assertInHTML(
-			srctag.format(url=transcoding2.url, type=transcoding2.type),
-			content,
-			count=0
-		)
-		self.assertInHTML(
-			srctag.format(url=transcoding3.url, type=transcoding3.type),
-			content,
-		)
-		self.assertInHTML(
-			srctag.format(url=transcoding4.url, type=transcoding4.type),
-			content,
+			'<a href="vid-1.html?quality=480p" onclick="vidTimeInUrl(this);">480p versie</a>',
+			content
 		)
+
+		self.assertInHTML('<strong>720p versie</strong>', content)