From 019adcba56e4fe42a3415776bfddf095278d511f Mon Sep 17 00:00:00 2001 From: Bastiaan Welmers Date: Thu, 21 May 2020 18:37:41 +0200 Subject: [PATCH] Uploads are already 'lazily' executed --- tests/videodinges/factories.py | 4 +--- tests/videodinges/test_factories/test_upload.py | 10 ++++++++++ 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/tests/videodinges/factories.py b/tests/videodinges/factories.py index 458bb89..4a09346 100644 --- a/tests/videodinges/factories.py +++ b/tests/videodinges/factories.py @@ -26,9 +26,7 @@ def create(model: Type[T], **kwargs) -> T: return _create_with_defaults(models.Transcoding, kwargs, **defaults) if model is models.Upload: - file = SimpleUploadedFile('some_file.txt', b'some contents') \ - if 'file' not in kwargs else None - return _create_with_defaults(models.Upload, kwargs, file=file) + return _create_with_defaults(models.Upload, kwargs, file=SimpleUploadedFile('some_file.txt', b'some contents')) def _create_with_defaults(model: Type[T], kwargs: dict, **defaults) -> T: diff --git a/tests/videodinges/test_factories/test_upload.py b/tests/videodinges/test_factories/test_upload.py index a53603f..be67a83 100644 --- a/tests/videodinges/test_factories/test_upload.py +++ b/tests/videodinges/test_factories/test_upload.py @@ -1,3 +1,6 @@ +import os + +from django.core.files.uploadedfile import SimpleUploadedFile from django.test import TestCase from tests.videodinges import factories, UploadMixin @@ -7,3 +10,10 @@ class UploadTestCase(UploadMixin, TestCase): def test_model_is_created(self): upload = factories.create(Upload) self.assertEqual(upload.file.name, 'some_file.txt') + self.assertTrue(os.path.exists(os.path.join(self.media_root.name, 'some_file.txt'))) + + def test_upload_does_not_create_file_when_providing_upload(self): + upload = factories.create(Upload, file=SimpleUploadedFile('my_file.txt', b'some contents')) + self.assertEqual(upload.file.name, 'my_file.txt') + self.assertFalse(os.path.exists(os.path.join(self.media_root.name, 'some_file.txt'))) + self.assertTrue(os.path.exists(os.path.join(self.media_root.name, 'my_file.txt')))